Skip to content

Restore support for non-qualified message names #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 16, 2025
Merged

Restore support for non-qualified message names #512

merged 2 commits into from
May 16, 2025

Conversation

scpeters
Copy link
Member

🎉 New feature

Part of gazebo-tooling/release-tools#1309.

Summary

Support for non-qualified message names in MessageFactory was removed in #476, but this is not yet supported in gz-transport (see gazebosim/gz-transport#634). Restore the functionality for now to facilitate version bumps and then try removing it later.

Test it

Check CI

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@scpeters
Restore support for non-qualified message names
dcac772 
Support for non-qualified message names in MessageFactory
was removed in #476, but this is not yet supported in
gz-transport. Restore the functionality for now to
facilitate version bumps and then try removing it later.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters requested a review from caguero as a code owner May 16, 2025 18:01
@scpeters scpeters mentioned this pull request May 16, 2025
Merged
@scpeters scpeters requested a review from iche033 May 16, 2025 18:03
iche033
iche033 approved these changes May 16, 2025
View reviewed changes
Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add a comment to mention that we can't remove this deprecation until support in gz-transport is ready

@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development May 16, 2025
@scpeters
Copy link
Member Author

maybe add a comment to mention that we can't remove this deprecation until support in gz-transport is ready

where? in MessageFactory.cc?

@scpeters
Update MessageFactory.cc
6be7202 
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters
Copy link
Member Author

maybe add a comment to mention that we can't remove this deprecation until support in gz-transport is ready

where? in MessageFactory.cc?

commented in 6be7202

@scpeters scpeters merged commit 08c8340 into main May 16, 2025
7 of 8 checks passed
@scpeters scpeters deleted the scpeters/restore_non_qualified_msg_factory branch May 16, 2025 18:38
@github-project-automation github-project-automation bot moved this from In review to Done in Core development May 16, 2025
@iche033
Copy link
Contributor

iche033 commented May 16, 2025

maybe add a comment to mention that we can't remove this deprecation until support in gz-transport is ready

where? in MessageFactory.cc?

commented in 6be7202

ah yes that looks good, thanks!

@scpeters scpeters mentioned this pull request May 16, 2025
Closed
scpeters added a commit that referenced this pull request Jun 1, 2025
@scpeters
Revert "Restore support for non-qualified message names (#512)"
22e377b 
This reverts commit 08c8340.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters mentioned this pull request Jun 1, 2025
Merged
10 tasks
scpeters added a commit that referenced this pull request Jun 3, 2025
@scpeters
Revert support for non-qualified message names (#520)
f1d2d8e 
This reverts commit 08c8340
from #512.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters mentioned this pull request Oct 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iche033 iche033 iche033 approved these changes

@caguero caguero Awaiting requested review from caguero caguero is a code owner

Assignees

No one assigned

Labels

None yet

Projects

Core development
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@scpeters @iche033